Commits · v19.4.0 · Test Group-nodejs / node

Jan 05, 2023

2023-01-06, Version 19.4.0 (Current) · e58ed6d8

RafaelGSS authored 2 years ago

Notable changes:

buffer:
  * (SEMVER-MINOR) add buffer.isUtf8 for utf8 validation (Yagiz Nizipli) https://github.com/nodejs/node/pull/45947
http:
  * (SEMVER-MINOR) improved timeout defaults handling (Paolo Insogna) https://github.com/nodejs/node/pull/45778
net
  * add autoSelectFamily global getter and setter (Paolo Insogna) https://github.com/nodejs/node/pull/45777
os:
  * (SEMVER-MINOR) add availableParallelism() (Colin Ihrig) https://github.com/nodejs/node/pull/45895
util:
  * add fast path for text-decoder fatal flag (Yagiz Nizipli) https://github.com/nodejs/node/pull/45803

PR-URL: https://github.com/nodejs/node/pull/46061

e58ed6d8

net: handle socket.write(cb) edge case · 4d62b099

Santiago Gimeno authored 2 years ago

Make sure that when calling `write()` on a connecting socket, the
callback is called if the socket is destroyed before the connection is
established.

Fixes: https://github.com/nodejs/node/issues/30841
PR-URL: https://github.com/nodejs/node/pull/45922


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

4d62b099

crypto: ensure exported webcrypto EC keys use uncompressed point format · 777c551e

Ben Noordhuis authored 2 years ago

The WebCrypto spec apparently mandates that EC keys must be exported in
uncompressed point format. This commit makes it so.

Fixes: https://github.com/nodejs/node/issues/45859
PR-URL: https://github.com/nodejs/node/pull/46021


Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>

777c551e

meta: update AUTHORS · 25d0a944

Node.js GitHub Bot authored 2 years ago

PR-URL: https://github.com/nodejs/node/pull/46040


Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

25d0a944

tools: update lint-md-dependencies to rollup@3.9.0 · 0f0d22a6

Node.js GitHub Bot authored 2 years ago

PR-URL: https://github.com/nodejs/node/pull/46039


Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

0f0d22a6

tools: update doc to unist-util-select@4.0.2 · 5a8d125f

Node.js GitHub Bot authored 2 years ago

PR-URL: https://github.com/nodejs/node/pull/46038


Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

5a8d125f

doc: update isUtf8 description · e113d169

Yagiz Nizipli authored 2 years ago

PR-URL: https://github.com/nodejs/node/pull/45973


Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

e113d169

tools: add release host var to promotion script · 54776ffe

Ruy Adorno authored 2 years ago


Adds a `NODEJS_RELEASE_HOST` environment variable that enable releasers
to provide a custom proxy host to connect to when performing the
promotion steps of a given release.

Signed-off-by: Ruy Adorno <ruyadorno@google.com>
PR-URL: https://github.com/nodejs/node/pull/45913


Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

54776ffe

lib: update JSDoc of `getOwnPropertyValueOrDefault` · 7f1daedf

Deokjin Kim authored 2 years ago

PR-URL: https://github.com/nodejs/node/pull/46010


Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

7f1daedf

events: fix violation of symbol naming convention · 47cc0e4b

Deokjin Kim authored 2 years ago

Capital letter is followed after 'k' prefix.

PR-URL: https://github.com/nodejs/node/pull/45978


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

47cc0e4b

deps: V8: cherry-pick 30861a39323d · fdda2ff5

Aaron Friel authored 2 years ago

Original commit message:

    [debug] Re-enable internal [[Scopes]] property

    We received feedback that the [[Scopes]] property has some legitimate
    use-cases not covered by the Scopes View during pause.

    We re-enable the feature for now and will remove the flag in a
    follow-up.

    R=bmeurer@chromium.org

    Bug: chromium:1365858
    Change-Id: Ibf279ae6c4f5ae492d03e9b4ee7316f6500508d9
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4099385


    Auto-Submit: Simon Zünd <szuend@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#84800}

Refs: https://github.com/v8/v8/commit/30861a39323d2d4263b2b9f5d9740134d4104cd3
PR-URL: https://github.com/nodejs/node/pull/45851


Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

fdda2ff5

vm: refactor to use `validateStringArray` · 389cc3e1

Deokjin Kim authored 2 years ago

PR-URL: https://github.com/nodejs/node/pull/46020


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

389cc3e1

async_hooks: refactor to use `validateObject` · 54b748ac

Deokjin Kim authored 2 years ago

PR-URL: https://github.com/nodejs/node/pull/46004


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

54b748ac

lib: use `kEmptyObject` as default value for options · 28f9089b

Deokjin Kim authored 2 years ago

`kEmptyObject` is more suitable than {} if options don't
need mutation.

PR-URL: https://github.com/nodejs/node/pull/46011


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

28f9089b

deps: patch V8 to 10.8.168.25 · 71bf5130

Michaël Zasso authored 2 years ago

Refs: https://github.com/v8/v8/compare/10.8.168.21...10.8.168.25
PR-URL: https://github.com/nodejs/node/pull/45996


Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

71bf5130

doc: sort http.createServer() options alphabetically · 9e164060

Luigi Pinca authored 2 years ago

PR-URL: https://github.com/nodejs/node/pull/45680


Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

9e164060

test: use `process.hrtime.bigint` instead of `process.hrtime` · 2807efae

Deokjin Kim authored 2 years ago

`process.hrtime` is legacy. So replace `process.hrtime` with
`process.hrtime.bigint` in test.

Refs: https://github.com/nodejs/node/blob/main/doc/api/process.md#processhrtimetime



Signed-off-by: Deokjin Kim <deokjin81.kim@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/45877
Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

2807efae

doc: use console.error for error case in timers and tls · 49253e1a

Deokjin Kim authored 2 years ago

console.error is more suitable than console.log for error case.

PR-URL: https://github.com/nodejs/node/pull/46002


Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

49253e1a

fs: refactor to use `validateInteger` · 22a66cff

Deokjin Kim authored 2 years ago

PR-URL: https://github.com/nodejs/node/pull/46008


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

22a66cff

stream: refactor to use `validateFunction` · ab22a8ff

Deokjin Kim authored 2 years ago

PR-URL: https://github.com/nodejs/node/pull/46007


Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

ab22a8ff

esm: rewrite loader hooks test · 2d49e0e6

Geoffrey Booth authored 2 years ago

Rewrite the test that validates that custom loader hooks are called from
being a test that depends on internals to one that spawns a child
process and checks its output to confirm expected behavior.

PR-URL: https://github.com/nodejs/node/pull/46016


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>

2d49e0e6

src: fix typo in `node_file.cc` · af25c95b

Vadim authored 2 years ago

`undefinec` -> `undefined`

PR-URL: https://github.com/nodejs/node/pull/45998


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

af25c95b

doc: fix wrong output of example in `url.protocol` · 8be1b666

Deokjin Kim authored 2 years ago

Tailing slash of url.href is ommited.

PR-URL: https://github.com/nodejs/node/pull/45954


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

8be1b666

stream: fix typo in JSDoc · 0858956f

Deokjin Kim authored 2 years ago

`vois` -> `void`

PR-URL: https://github.com/nodejs/node/pull/45991


Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

0858956f

src: fix crash on OnStreamRead on Windows · 261d6d07

Santiago Gimeno authored 2 years ago

On Windows it's perfectly possible that the `uv_tcp_t` `read_cb` is
called with an error and a null `uv_buf_t` if it corresponds to a
`UV_HANDLE_ZERO_READ` read. Handle this case without crashing.

Fixes: https://github.com/nodejs/node/issues/40764
PR-URL: https://github.com/nodejs/node/pull/45878


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

261d6d07

debugger: refactor console in lib/internal/debugger/inspect.js · 3d097541

Debadree Chatterjee authored 2 years ago

Refs: https://github.com/nodejs/node/pull/38406/
PR-URL: https://github.com/nodejs/node/pull/45847


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>

3d097541

doc: use `os.availableParallelism()` in async_context and cluster · 9251dce8

Deokjin Kim authored 2 years ago

Refs: https://github.com/nodejs/node/pull/45895
PR-URL: https://github.com/nodejs/node/pull/45979


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

9251dce8

http: replace `var` with `const` on code of comment · bc439229

Deokjin Kim authored 2 years ago

`const` or `let` is more preferred than `var` except iteration.

PR-URL: https://github.com/nodejs/node/pull/45951


Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

bc439229

src: add worker per-isolate binding initialization · 6c5b7e66

Chengzhong Wu authored 2 years ago

Create worker binding templates in the per-isolate initialization.

PR-URL: https://github.com/nodejs/node/pull/45547
Refs: https://github.com/nodejs/node/issues/42528


Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

6c5b7e66

src: define per-isolate internal bindings registration callback · db535b6c

Chengzhong Wu authored 2 years ago

Bindings that need to be loaded in distinct contexts of node::Realm in
the same node::Environment instance needs to share the per-isolate
templates.

Add a new binding registration callback, which is called with
per-IsolateData. This allows bindings to define templates and
share them across realms eagerly, and avoid accidental modification on
the templates when the per-context callback is called multiple times.

This also tracks loaded bindings and built-in modules with node::Realm.

PR-URL: https://github.com/nodejs/node/pull/45547
Refs: https://github.com/nodejs/node/issues/42528


Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

db535b6c

deps: update simdutf to 2.0.9 · 0552b132

Node.js GitHub Bot authored 2 years ago

PR-URL: https://github.com/nodejs/node/pull/45975


Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

0552b132

doc: make EventEmitterAsyncResource's `options` as optional · 952e03ae

Deokjin Kim authored 2 years ago

Refs: https://github.com/nodejs/node/blob/main/lib/events.js#L140
PR-URL: https://github.com/nodejs/node/pull/45985


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

952e03ae

tools: add url to `AUTHORS` update automation · f968fdb7

Antoine du Hamel authored 2 years ago

This should simplify the review of `AUTHORS` file updates.

PR-URL: https://github.com/nodejs/node/pull/45971


Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

f968fdb7

deps: update to uvwasi 0.0.14 · e73be1b3

Colin Ihrig authored 2 years ago

Notable changes:

- Windows applications not in ConsoleMode now properly guess
  handle types for FILE_TYPE_CHAR file types which cannot be
  stat'ed.
- The UVWASI_DEBUG macro can now be used without a format string.
- The libuv dependency has been updated to v1.44.2.

PR-URL: https://github.com/nodejs/node/pull/45970


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

e73be1b3

test_runner: use os.availableParallelism() · 7ae24abd

Colin Ihrig authored 2 years ago

This commit addresses an existing TODO in the code by moving
to the new os.availableParallelism() instead of os.cpus().length.

PR-URL: https://github.com/nodejs/node/pull/45969


Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

7ae24abd

meta: update AUTHORS · 0a70316e

Node.js GitHub Bot authored 2 years ago

PR-URL: https://github.com/nodejs/node/pull/45968


Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rich Trott <rtrott@gmail.com>

0a70316e

tools: update lint-md-dependencies to rollup@3.8.1 · 7c518cba

Node.js GitHub Bot authored 2 years ago

PR-URL: https://github.com/nodejs/node/pull/45967


Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

7c518cba

test: print failed JS/parallel tests · 0f5a1459

Geoffrey Booth authored 2 years ago

PR-URL: https://github.com/nodejs/node/pull/45960


Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Christian Clauss <cclauss@me.com>

0f5a1459

deps: fix updater github workflow job · e4323f01

Yagiz Nizipli authored 2 years ago

PR-URL: https://github.com/nodejs/node/pull/45972


Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

e4323f01

doc: replace single executable champion in strategic initiatives doc · 71cc3b37

Darshan Sen authored 2 years ago


Jesse has informed me that he won't be able to contribute to this
initiative, unfortunately. If you would like to know why, feel free to
ask him or me privately. I would like to take over.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/45956


Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

71cc3b37