Skip to content
Snippets Groups Projects
  1. Nov 21, 2024
  2. Nov 20, 2024
  3. Nov 19, 2024
  4. Nov 18, 2024
    • zzak's avatar
      Fix "Test is missing assertions" is caught by Strict Warnings · 71223ba6
      zzak authored
      ```
      $ RAILS_STRICT_WARNINGS=1 bin/test \
        test/application/generators_test.rb \
        test/application/initializers/frameworks_test.rb \
        test/application/loading_test.rb \
        test/application/rake/tmp_test.rb \
        test/application/rake_test.rb
      
      Run options: --seed 7309
      
      .............................Test is missing assertions: `test_tmp:clear_should_work_if_folder_missing` /home/zzak/code/rails/railties/test/application/rake/tmp_test.rb:41
      E
      
      Error:
      ApplicationTests::RakeTests::TmpTest#test_tmp:clear_should_work_if_folder_missing:
      ActiveSupport::RaiseWarnings::WarningError: Test is missing assertions: `test_tmp:clear_should_work_if_folder_missing` /home/zzak/code/rails/railties/test/application/rake/tmp_test.rb:41
      
          /home/zzak/code/rails/activesupport/lib/active_support/testing/strict_warnings.rb:38:in `warn'
      
      bin/test test/application/rake/tmp_test.rb:41
      
      Test is missing assertions: `test_ARGV_is_populated` /home/zzak/code/rails/railties/test/application/generators_test.rb:180
      E
      
      Error:
      ApplicationTests::GeneratorsTest#test_ARGV_is_populated:
      ActiveSupport::RaiseWarnings::WarningError: Test is missing assertions: `test_ARGV_is_populated` /home/zzak/code/rails/railties/test/application/generators_test.rb:180
      
          /home/zzak/code/rails/activesupport/lib/active_support/testing/strict_warnings.rb:38:in `warn'
      
      bin/test test/application/generators_test.rb:180
      
      ......Test is missing assertions: `test_can_boot_with_an_unhealthy_database` /home/zzak/code/rails/railties/test/application/initializers/frameworks_test.rb:219
      E
      
      Error:
      ApplicationTests::FrameworksTest#test_can_boot_with_an_unhealthy_database:
      ActiveSupport::RaiseWarnings::WarningError: Test is missing assertions: `test_can_boot_with_an_unhealthy_database` /home/zzak/code/rails/railties/test/application/initializers/frameworks_test.rb:219
      
          /home/zzak/code/rails/activesupport/lib/active_support/testing/strict_warnings.rb:38:in `warn'
      
      bin/test test/application/initializers/frameworks_test.rb:219
      
      ...............................Test is missing assertions: `test_loading_only_yml_fixtures` /home/zzak/code/rails/railties/test/application/rake_test.rb:202
      E
      
      Error:
      ApplicationTests::RakeTest#test_loading_only_yml_fixtures:
      ActiveSupport::RaiseWarnings::WarningError: Test is missing assertions: `test_loading_only_yml_fixtures` /home/zzak/code/rails/railties/test/application/rake_test.rb:202
      
          /home/zzak/code/rails/activesupport/lib/active_support/testing/strict_warnings.rb:38:in `warn'
      
      bin/test test/application/rake_test.rb:202
      
      ...Test is missing assertions: `test_models_without_table_do_not_panic_on_scope_definitions_when_loaded` /home/zzak/code/rails/railties/test/application/loading_test.rb:82
      E
      
      Error:
      LoadingTest#test_models_without_table_do_not_panic_on_scope_definitions_when_loaded:
      ActiveSupport::RaiseWarnings::WarningError: Test is missing assertions: `test_models_without_table_do_not_panic_on_scope_definitions_when_loaded` /home/zzak/code/rails/railties/test/application/loading_test.rb:82
      
          /home/zzak/code/rails/activesupport/lib/active_support/testing/strict_warnings.rb:38:in `warn'
      
      bin/test test/application/loading_test.rb:82
      ```
      
      This doesn't fail in CI because the warning is using a relative path:
      
      ```
      Test is missing assertions: `test_tmp:clear_should_work_if_folder_missing` test/application/rake/tmp_test.rb:41
      ```
      
      Ref: https://buildkite.com/rails/rails/builds/113871#01933e25-4b3c-47f9-9b74-ea4ac84c6ae2/1292-1298
      
      This can be reproduced locally like so:
      
      ```
      RAILS_STRICT_WARNINGS=true ruby -w -Itest -Ilib -I../activesupport/lib -I../actionpack/lib -I../actionview/lib -I../activemodel/lib test/application/rake/tmp_test.rb
      
      /home/zzak/.rbenv/versions/3.3.6/lib/ruby/gems/3.3.0/gems/bundler-2.5.16/lib/bundler/rubygems_ext.rb:250: warning: method redefined; discarding old encode_with
      /home/zzak/.rbenv/versions/3.3.6/lib/ruby/3.3.0/rubygems/dependency.rb:341: warning: previous definition of encode_with was here
      Run options: --seed 35733
      
      Test is missing assertions: `test_tmp:clear_should_work_if_folder_missing` /home/zzak/code/rails/railties/test/application/rake/tmp_test.rb:41
      E.
      
      Finished in 0.118110s, 16.9334 runs/s, 33.8668 assertions/s.
      
        1) Error:
      ApplicationTests::RakeTests::TmpTest#test_tmp:clear_should_work_if_folder_missing:
      ActiveSupport::RaiseWarnings::WarningError: Test is missing assertions: `test_tmp:clear_should_work_if_folder_missing` /home/zzak/code/rails/railties/test/application/rake/tmp_test.rb:41
      
          /home/zzak/code/rails/activesupport/lib/active_support/testing/strict_warnings.rb:38:in `warn'
      
      2 runs, 4 assertions, 0 failures, 1 errors, 0 skips
      ```
      71223ba6
    • fatkodima's avatar
    • Ryuta Kamizono's avatar
      Merge pull request #53626 from... · 4df235f7
      Ryuta Kamizono authored
      Merge pull request #53626 from viralpraxis/add-actiondispatch-request-session-store-method-to-conform-rack-spec
      
      Add `ActionDispatch::Request::Session#store` method to conform Rack spec
      4df235f7
    • viralpraxis's avatar
      Add ActionDispatch::Request::Session#store method. · 226d7c68
      viralpraxis authored
      
      Rack specification states that a hash-like object
      stored in environment with `rack.session` key
      MUST implement `store/2` method.
      
      Without the alias, this test fails with the following:
      
      ```
      Exception while processing request: Rack::Lint::LintError: session #<ActionDispatch::Request::Session:0x3570 not yet loaded> must respond to store and []=
          /home/zzak/.rbenv/versions/3.3.6/lib/ruby/gems/3.3.0/gems/rack-3.1.8/lib/rack/lint.rb:206:in `check_environment'
          /home/zzak/.rbenv/versions/3.3.6/lib/ruby/gems/3.3.0/gems/rack-3.1.8/lib/rack/lint.rb:63:in `response'
          /home/zzak/.rbenv/versions/3.3.6/lib/ruby/gems/3.3.0/gems/rack-3.1.8/lib/rack/lint.rb:41:in `call'
          lib/action_dispatch/middleware/cookies.rb:706:in `call'
          /home/zzak/.rbenv/versions/3.3.6/lib/ruby/gems/3.3.0/gems/rack-session-2.0.0/lib/rack/session/abstract/id.rb:272:in `context'
          /home/zzak/.rbenv/versions/3.3.6/lib/ruby/gems/3.3.0/gems/rack-session-2.0.0/lib/rack/session/abstract/id.rb:266:in `call'
          /home/zzak/.rbenv/versions/3.3.6/lib/ruby/gems/3.3.0/gems/rack-3.1.8/lib/rack/head.rb:15:in `call'
          /home/zzak/.rbenv/versions/3.3.6/lib/ruby/gems/3.3.0/gems/rack-3.1.8/lib/rack/method_override.rb:28:in `call'
          lib/action_dispatch/middleware/cookies.rb:706:in `call'
          lib/action_dispatch/middleware/callbacks.rb:31:in `block in call'
          /home/zzak/code/rails/activesupport/lib/active_support/callbacks.rb:100:in `run_callbacks'
          lib/action_dispatch/middleware/callbacks.rb:30:in `call'
          lib/action_dispatch/middleware/actionable_exceptions.rb:18:in `call'
          lib/action_dispatch/middleware/debug_exceptions.rb:31:in `call'
          lib/action_dispatch/middleware/show_exceptions.rb:32:in `call'
          test/abstract_unit.rb:110:in `call'
          /home/zzak/.rbenv/versions/3.3.6/lib/ruby/gems/3.3.0/gems/rack-test-2.1.0/lib/rack/test.rb:360:in `process_request'
          /home/zzak/.rbenv/versions/3.3.6/lib/ruby/gems/3.3.0/gems/rack-test-2.1.0/lib/rack/test.rb:153:in `request'
          lib/action_dispatch/testing/integration.rb:297:in `process'
          lib/action_dispatch/testing/integration.rb:19:in `get'
          lib/action_dispatch/testing/integration.rb:388:in `get'
          test/dispatch/request/session_test.rb:224:in `test_session_follows_rack_api_contract_1'
      ```
      
      Co-authored-by: default avatarviralpraxis <iaroslav2k@gmail.com>
      Co-authored-by: default avatarzzak <zzakscott@gmail.com>
      Co-authored-by: default avatarHartley McGuire <skipkayhil@gmail.com>
      226d7c68
  5. Nov 17, 2024
  6. Nov 16, 2024
Loading